Early WIP on v2.55

[Michael Lobko-Lobanovsky]

From what I can see immediately:

0. FPS counter gets shifted away together with gP.hGL. I think it should stay in view, i.e. be positioned relative to the gP.hMain frame and lighting panel if it is visible.

1. If the splitter is shifted, then when the toast window is visible and gP.hMain is moved (dragged around), the toast window gets misplaced too far to the left.

2. Splitter/gP.hGL position isn't restored when the main window is restored from maximized to normal (as you said).

3. Double click is intercepted but not yet implemented as intended.

Is that all correct?

[Patrice Terrier]

I shall look at this tomorrow.
Have a good sleep!

[Patrice Terrier]

Could you remind me what the double click must do exactly, i must have removed inadvertently your previous post about this. 

I think to remember that the splitter must jump directly to the center of the viewport using a scrolling effect like for the control panel, am i right?

[Michael Lobko-Lobanovsky]

Yes, when it's double clicked in its rightmost position, it should scroll quickly to the viewport center. When in any other position, it should scroll to the rightmost position.

[Patrice Terrier]

Here is my patch.

Note: Because the gP.hGL is using ANCHOR_HEIGHT_WIDTH, when switching from maximized to restore the rw.right could become negative, then in this case the splitter is constraint to the left border size.

WM_NCLBUTTONDBLCLK is compatible with light or mesh animation(s).

[Michael Lobko-Lobanovsky]

Thank you, Patrice!

The main glitch I'm seeing is that when the splitter is somewhere midway and the lighting panel is visible, the panel stays OK when the main window is dragged around the screen. But it still jumps to the left (sometimes completely off screen) when the main window is resized rather than dragged.

I increased nStep to 50. The double click is primarily meant as an accelerator rather than eye candy.

[Michael Lobko-Lobanovsky]

Another glitch is when I stretch the main window across 1.5 monitors and bring the splitter closer to the left border, and then resize the window horizontally smaller by dragging its right border to the left, the splitter flies outta the main window and slides to the left of it and away over the screen left border.

[Michael Lobko-Lobanovsky]

This way it produces much less smear in the left portion of gP.hGL after the double click:

SplitterCallBack():

........
        if (gP.splitXoffset == 0) { // Move to center
            gP.splitXoffset = (w - SPLITTER_WIDTH) / 2;
            for (x = 0; x <= gP.splitXoffset; x += nStep) {
                MoveWindow(gP.hGL, -x, 0, w, h, TRUE);
                MoveSplitter();
                gP.redraw = -1;  gl_DrawScene();//SendMessage(gP.hMain, WM_SYNC_NOTIFY, 0, 0); // Let the animation play while moving the window
                //Sleep(0);
            }
        } else { // Dock to the right
            for (x = WasXoffset; x >= 0; x -= nStep) {
                MoveWindow(gP.hGL, -x, 0, w, h, TRUE);
                MoveSplitter();
                gP.redraw = -1;  gl_DrawScene();//SendMessage(gP.hMain, WM_SYNC_NOTIFY, 0, 0); // Let the animation play while moving the window
                //Sleep(0);
            }
            gP.splitXoffset = 0;
        }
........

[Patrice Terrier]

error C3861: 'gl_DrawScene': identifier not found

Where did you put the include file?
(or did you move the procedure gl_Drawscene elsewhere)

I couldn't reproduce the two behaviors you describe in post #326 and #327.

Could you create a quick video with the nVidia utility to show me how to reproduce this?

[Patrice Terrier]

New MoveSplitter for the problem reported in post #327

Code: [Select]

void MoveSplitter() {
    RECT lpr; GetWindowRect(gP.hGL, &lpr);
    RECT rw; GetViewRect(gP.hMain, &rw);
    //zTrace(L"-----");
    //zTrace(STRL(lpr.right));
    //zTrace(STRL(SPLITTER_WIDTH));
    //zTrace(STRL(rw.left));
    if (lpr.right < rw.left) {
        MoveWindow(gP.hSplitter, rw.left, rw.top, SPLITTER_WIDTH, Height(rw), TRUE);
    } else {
        MoveWindow(gP.hSplitter, lpr.right, lpr.top, SPLITTER_WIDTH, Height(rw), TRUE);
    }
}

[Michael Lobko-Lobanovsky]

Tonight's handicraft:

[Patrice Terrier]

My friend, i know you were kept very busy, and i wonder when you take time to go to sleep 

Great work!

[Michael Lobko-Lobanovsky]

Here's the patch with my nightly mods.

[Michael Lobko-Lobanovsky]

Patrice,

I'm still not feeling well, and my sleep is often broken with difficult breath. So, it's easier to stay awake.

BTW does your skinned main menu have any limitations as to the number of elements? My 7th (Help) element won't show up and it seems I can only specify 6 of them...

[Michael Lobko-Lobanovsky]

I couldn't reproduce the two behaviors you describe in post #326 and #327.

Could you create a quick video with the nVidia utility to show me how to reproduce this?

Patrice,

We're using different OS'es, video cards, and drivers. My main PC also works simultaneously with 2 nVidia monitors and 1 Intel monitor. All this may cause various glitches, which however may be minimized one way or another.

You're cleaning up the thread often and the message numbers aren't valid any more. Obviously, you spoke about the splitter flying out of the main window and smear near the left border? If yes then you've corrected the splitter behavior, and what concerns the smear, I saw your video that shows smooth gP.hGL scrolling while mine shows smear when gP.hGL has a long way to go to the right. But my suggested fixes cure this problem almost completely, and if you're all right with them under your W10 then let them stay in the code for the sake of my Win7.